----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/#review105352 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 276) <https://reviews.apache.org/r/38579/#comment163908> Remove redundant check from above. src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 291) <https://reviews.apache.org/r/38579/#comment163909> None of our onXXXXX callbacks with futures should return anything, since it has no effect! Just remove this onDiscard if you're not really doing anything here. src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 445) <https://reviews.apache.org/r/38579/#comment163910> Can you use the new .status == http::Status::OK and simliar checks here? - Timothy Chen On Nov. 5, 2015, 7:17 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38579/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 7:17 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > - Cleanup and broke big methods into smaller chunks. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp > ad57d8592c5f9df5115b575855ed2e99a0597359 > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c > src/tests/containerizer/provisioner_docker_tests.cpp > 8d90894410cd834edf49a2814d1b616718798fe8 > > Diff: https://reviews.apache.org/r/38579/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
