> On Nov. 5, 2015, 3:59 p.m., Neil Conway wrote: > > Can we add an end-to-end unit test that verifies that attempting to > > register as a framework with an invalid role name results in an error?
Attempting to register with an unrecognized role name will fail long before we get to creating a directory for it on the slave. Rather, the validation/testing needs to happen when we add a new role, which currently only happens on master startup with `--roles`. We could/should have a test for a framework attempting to register with an unrecognized role, but that's unrelated to this patch. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review105316 ----------------------------------------------------------- On Oct. 3, 2015, 9:11 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2015, 9:11 a.m.) > > > Review request for mesos, Adam B, Jie Yu, and Michael Park. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > include/mesos/roles.hpp PRE-CREATION > src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 > src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 > src/common/roles.cpp PRE-CREATION > src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 > src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c > src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b > src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 > src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 > src/tests/roles_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
