-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37022/#review105408
-----------------------------------------------------------

Ship it!


Sorry this slipped through the cracks. Somehow the patch still applies without 
a rebase. If you can update the comments I'll get this committed asap.


include/mesos/mesos.proto (lines 1340 - 1342)
<https://reviews.apache.org/r/37022/#comment163998>

    This comment (and the Visibility message?) may be more appropriate up by 
Port now.
    
    Can you add a comment here or there explaining how the (required) 
DiscoveryInfo.visibility relates to (optional) Port.visibility? I'd assume the 
per-port visibility overrides the default service-wide DiscoverInfo.visibility.


- Adam B


On Aug. 4, 2015, 2:25 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37022/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2015, 2:25 a.m.)
> 
> 
> Review request for mesos, Adam B, Christos Kozyrakis, and Michael Park.
> 
> 
> Bugs: MESOS-2960
>     https://issues.apache.org/jira/browse/MESOS-2960
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow Visibility per port in DiscoveryInfo.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/common/type_utils.cpp 36a2469274abb356376279cf7c2f88cf29c2796e 
>   src/tests/master_tests.cpp 2aea430951d40d8fe78f656b1269c5e55a0802db 
> 
> Diff: https://reviews.apache.org/r/37022/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to