> On Nov. 5, 2015, 1:33 p.m., Adam B wrote: > > src/common/resources.cpp, lines 471-472 > > <https://reviews.apache.org/r/39018/diff/17/?file=1115706#file1115706line471> > > > > Why wrap here? Wasn't this previously 80 chars exactly?
It was 80 previously, but now we have 2 additional indent characters. > On Nov. 5, 2015, 1:33 p.m., Adam B wrote: > > src/common/resources.cpp, lines 457-458 > > <https://reviews.apache.org/r/39018/diff/17/?file=1115706#file1115706line457> > > > > We only indent 2 characters when continuing an assignment ('=') on a > > newline. > > See `grep -rn -A1 "=$" src/` Whoops sorry, introduced this one with my last set of changes. > On Nov. 5, 2015, 1:33 p.m., Adam B wrote: > > src/tests/resources_tests.cpp, lines 235-236 > > <https://reviews.apache.org/r/39018/diff/17/?file=1115707#file1115707line235> > > > > A panda is more than just a number. They have names too. See > > https://en.wikipedia.org/wiki/List_of_giant_pandas I apologize to any pandas whom I may have offended. The test pandas have been given the names they truly deserve. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review105234 ----------------------------------------------------------- On Nov. 4, 2015, 4:21 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39018/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 4:21 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael > Park. > > > Bugs: MESOS-2467 > https://issues.apache.org/jira/browse/MESOS-2467 > > > Repository: mesos > > > Description > ------- > > This includes code changes necessary for JSON parsing of Resources. > Documentation changes will be posted soon in another review > (https://reviews.apache.org/r/39102/). > > > Diffs > ----- > > include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 > include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 > src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 > src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 > src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 > > Diff: https://reviews.apache.org/r/39018/diff/ > > > Testing > ------- > > New code was added to `ResourcesTest.ParsingFromJSON`, and two new tests were > added: `ResourcesTest.ParsingFromJSONWithRoles` and > `ResourcesTest.ParsingFromJSONError`. These attempt to test common error > scenarios that might show up in user-supplied JSON. > > `make check` was used to confirm that all tests pass. > > The original resources parsing format is used throughout many other tests > (check `src/tests/sorter_tests.cpp`, for example), so it's clear that the > original parsing continues to work correctly. > > > Thanks, > > Greg Mann > >
