> On Nov. 7, 2015, 9:36 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 51 > > <https://reviews.apache.org/r/38580/diff/24/?file=1118727#file1118727line51> > > > > This is no longer true since we pulled these out of RemotePuller right? > > Same as all the other ones.
No its part of RegistryPuller - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105579 ----------------------------------------------------------- On Nov. 8, 2015, 4:58 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38580/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2015, 4:58 p.m.) > > > Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Integrated remote puller with store. Tests will follow. > > > Diffs > ----- > > src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 > src/Makefile.am c479acafc92b7e9d078729d443b0d2f00d40f353 > src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp > 87d80026939a326bd1169f46906e36d6ef19f546 > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > f314f20d989ed0125e15d2a14d0f8e56c56976d5 > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 8010b8aa75a2fc2e4b537f915f9dca028e407b63 > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2 > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp > bc487d34e4087fa53452d63416d0f31e77060eb0 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp > PRE-CREATION > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > PRE-CREATION > src/slave/containerizer/mesos/provisioner/docker/store.cpp > bb02d650e16d45fcf337a7954f7a26143fb2c69f > src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 > src/slave/flags.cpp 825b6127dfbc39cb3aea852875eaaab95bac0516 > src/tests/containerizer/provisioner_docker_tests.cpp > fe6a90fe32364eec8ef923a000db19183603c338 > > Diff: https://reviews.apache.org/r/38580/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
