> On Nov. 5, 2015, 12:24 p.m., Joseph Wu wrote:
> > src/master/quota_handler.cpp, lines 83-88
> > <https://reviews.apache.org/r/38059/diff/13/?file=1116697#file1116697line83>
> >
> >     Why don't you just parse a QuotaInfo object instead of a 
> > form-serialized body (with JSON components)?
> >     
> >     The maintenance endpoints do this for simplicity.
> 
> Alexander Rukletsov wrote:
>     Because we didn't want to expose the internal structure (`QuotaInfo`) to 
> the outside world. In the future we may want to allow operators to set quotas 
> for multiple roles in one call, which we can easier do if we do not tie the 
> operator API to `QuotaInfo` protobuf. Does it make sense?

`QuotaInfo` should already be exposed, since it's in the `include` folder.

As for setting multiple `QuotaInfo`s in a single call, wouldn't that be simpler 
to implement via a JSON array?
(Maybe you can parse the request body as an array, but reject calls with more 
than one quota request in the MVP.)


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38059/#review105296
-----------------------------------------------------------


On Nov. 9, 2015, 8:39 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38059/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 8:39 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Processing quota request consists of several stages: request validation, 
> sanity check and so on. This patch creates a basic workflow for quota 
> requests, while the stages are implemented in subsequent patches.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
>   src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota.hpp PRE-CREATION 
>   src/master/quota.cpp PRE-CREATION 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38059/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to