> On Oct. 13, 2015, 3:35 p.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, line 60 > > <https://reviews.apache.org/r/38059/diff/3/?file=1088987#file1088987line60> > > > > Should we follow the pattern of other validation routines where we use > > the validation namespace and pull these utility routines into a separate > > file? > > > > I think we can separate the validation of the request from the content > > of the protobuf. Syntax vs. semantic. > > > > See maintenance as an example. > > Alexander Rukletsov wrote: > The reason it's conflated into one function is because in order to do > proper validation we should convert JSON to protobuf. Some checks are > performed with the JSON object and some with the converted protobuf. I though > that having three functions `validateJSON`, `convertToQuotaInfo`, and > `validateQuotaInfo` is too much. > > Joseph Wu wrote: > What specific validation are you doing to the JSON objects (other than > converting to Protobuf)? And why can't the validation wait until after the > JSON->Protobuf conversion sufficient?
Let's discuss this in the next review https://reviews.apache.org/r/39285/, where validation is actually implemented. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/#review102247 ----------------------------------------------------------- On Nov. 5, 2015, 7:28 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38059/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 7:28 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > ------- > > Processing quota request consists of several stages: request validation, > sanity check and so on. This patch creates a basic workflow for quota > requests, while the stages are implemented in subsequent patches. > > > Diffs > ----- > > src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38059/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
