> On Nov. 6, 2015, 2:58 p.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 1
> > <https://reviews.apache.org/r/36913/diff/21/?file=1114591#file1114591line1>
> >
> >     It seems other feature named file without "_handler"; any consideration 
> > for it?
> 
> Joerg Schad wrote:
>     In this case the file acutally only includes the handler part (basically 
> in order not to overload the http code) and hence the name seems to be 
> precise.

We can re-visit this later if we find the pattern here doesn't warrant the 
`_handler` extension. Dropping for now.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review105425
-----------------------------------------------------------


On Nov. 9, 2015, 11:10 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 11:10 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, 
> and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added /quota HTTP Endpoint for Quota handling.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
>   src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36913/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to