----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38876/#review105807 -----------------------------------------------------------
Ship it! Thanks, just some small cleanups and we should be all set. Would you mind adding a bit more context to the description to explain more specifically what the marker is used for? src/slave/paths.hpp (line 185) <https://reviews.apache.org/r/38876/#comment164464> How about getExecutorHttpMarkerPath per my other suggestion? src/slave/paths.cpp (line 53) <https://reviews.apache.org/r/38876/#comment164463> How about just HTTP_MARKER_FILE and "http.marker" to make this more symettric with the libprocess pid file stuff? - Ben Mahler On Nov. 7, 2015, 1:07 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38876/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2015, 1:07 a.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-3515 > https://issues.apache.org/jira/browse/MESOS-3515 > > > Repository: mesos > > > Description > ------- > > This change adds the relevant functionality to `src/slave/paths.cpp/hpp` to > store a marker file to denote HTTP based executors. We create the file when > `checkpointing` is enabled as part of handling the `Subscribe` request. This > is then used by the agent when recovering to ascertain if the executor was > connected via `HTTP` before the agent restart. > > > Diffs > ----- > > src/slave/paths.hpp f743fb4b1ca278fade9134e0ae8f6a6450d4a977 > src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 > > Diff: https://reviews.apache.org/r/38876/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
