----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/#review106391 -----------------------------------------------------------
src/master/master.hpp (line 1978) <https://reviews.apache.org/r/38059/#comment165136> Suggestion: move this to the end of the struct, ca. line 1983 and change the comment to this. "NOTE: There is no direct representation of quota information here to support that the operator can associate quota (by name) with a role before the role is created. Such ordering of operator requests prevents a race of premature unbounded allocation that setting quota first is intended to contain. The dynamic role/quota relation is administrated by the master instance." - Bernd Mathiske On Nov. 10, 2015, 8:19 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38059/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 8:19 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > ------- > > Processing quota request consists of several stages: request validation, > sanity check and so on. This patch creates a basic workflow for quota > requests, while the stages are implemented in subsequent patches. > > > Diffs > ----- > > src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb > src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota.hpp PRE-CREATION > src/master/quota.cpp PRE-CREATION > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38059/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
