----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38059/#review105801 -----------------------------------------------------------
Let's just try and make this chain a little easier to follow. Right now the reviews are heavily inter-leaved. src/master/quota_handler.cpp (line 48) <https://reviews.apache.org/r/38059/#comment164451> Let's sync this to a `Try<Nothing>` to avoid confusion. src/master/quota_handler.cpp (lines 63 - 67) <https://reviews.apache.org/r/38059/#comment164452> Let's just leave the comment here, since Joerg is implementing this validation. This will reduce the rebasing overhead. src/master/quota_handler.cpp (line 69) <https://reviews.apache.org/r/38059/#comment164453> Let's just construct a dummy `QuotaInfo` here (like your did above) to avoid the intricate dependency between this and the next patch. src/master/quota_handler.cpp (line 74) <https://reviews.apache.org/r/38059/#comment164454> We're prefacing what is bout to happen here, right? s/Populated/Populate/ s/We do it/We do this src/master/quota_handler.cpp (line 79) <https://reviews.apache.org/r/38059/#comment164455> Can we initialize this as `quota = {quotaInfo}`? src/master/quota_handler.cpp (line 82) <https://reviews.apache.org/r/38059/#comment164457> s/Update registry/Update the registry/ - Joris Van Remoortere On Nov. 9, 2015, 11:14 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38059/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 11:14 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > ------- > > Processing quota request consists of several stages: request validation, > sanity check and so on. This patch creates a basic workflow for quota > requests, while the stages are implemented in subsequent patches. > > > Diffs > ----- > > src/CMakeLists.txt f6ae05d4652df6de98a9e110efed87f7fcbd29f9 > src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota.hpp PRE-CREATION > src/master/quota.cpp PRE-CREATION > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38059/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
