> On Nov. 13, 2015, 10:33 a.m., Neil Conway wrote: > > include/mesos/mesos.proto, line 623 > > <https://reviews.apache.org/r/40118/diff/1/?file=1124444#file1124444line623> > > > > Note that this will require changes in the HTTP endpoint patch. (Just > > observing that whichever patch gets committed first, the other will need to > > be updated.)
Yea that's true. I have an issue open (MESOS-3903) to add authorization support to the `/create-volume` and `/destroy-volume` HTTP endpoints; I figured I would split that work off into a separate ticket to avoid a dependency on your HTTP endpoint patches. Currently in this series, there are several comments (including this one) which suggest that authorization support for endpoints is being added here as well; perhaps I should avoid making that claim right now and add endpoint support into the comments/docs when MESOS-3903 is being addressed. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40118/#review106393 ----------------------------------------------------------- On Nov. 13, 2015, 1:22 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40118/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 1:22 a.m.) > > > Review request for mesos, Jie Yu, Michael Park, and Neil Conway. > > > Bugs: MESOS-3064 > https://issues.apache.org/jira/browse/MESOS-3064 > > > Repository: mesos > > > Description > ------- > > Added 'principal' field to 'Resource.DiskInfo.Persistence'. > > > Diffs > ----- > > include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b > include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b > > Diff: https://reviews.apache.org/r/40118/diff/ > > > Testing > ------- > > This is the first in a chain of 7 patches. `make check` was used to test > after all patches were applied. > > Note that this chain of patches touches many of the same files as another > chain beginning with Review #39985 and ending with Review #39989, which is > currently in review as well. To avoid conflicts, the beginning of this chain > begins on top of Review #39989. > > One additional patch with documentation is forthcoming. > > > Thanks, > > Greg Mann > >
