----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ -----------------------------------------------------------
(Updated Nov. 17, 2015, 2:37 p.m.) Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff. Changes ------- Third round of reviews. Bugs: MESOS-3756 https://issues.apache.org/jira/browse/MESOS-3756 Repository: mesos Description ------- Adds support for modularization of HTTP Authenticators. It includes an example of how to do it with the Basic HTTP Authenticator. Diffs (updated) ----- include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION include/mesos/module/http_authenticator.hpp PRE-CREATION src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION src/examples/test_http_authenticator_module.cpp PRE-CREATION src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 src/tests/http_authentication_tests.cpp PRE-CREATION src/tests/module.hpp 04f42dc4f687e55c4e6758ef2f7c7096f1b1ec47 src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f Diff: https://reviews.apache.org/r/38950/diff/ Testing ------- make check Thanks, Alexander Rojas