----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/#review107181 -----------------------------------------------------------
src/tests/master_quota_tests.cpp (line 435) <https://reviews.apache.org/r/39614/#comment166178> let's wrap "from" to avoid jaggedness. src/tests/master_quota_tests.cpp (line 443) <https://reviews.apache.org/r/39614/#comment166181> Don't we need to authenticate? src/tests/master_quota_tests.cpp (lines 455 - 456) <https://reviews.apache.org/r/39614/#comment166177> It feels like this test may not test what it should. The field may miss for two reasons: no quotas set _or_ there is no such field at all : ). I'd suggest to either convert to the protobuf and then check the size of the collection, or check against entire `JSON` object. src/tests/master_quota_tests.cpp (line 479) <https://reviews.apache.org/r/39614/#comment166171> indent src/tests/master_quota_tests.cpp (lines 479 - 480) <https://reviews.apache.org/r/39614/#comment166172> blank line src/tests/master_quota_tests.cpp (line 490) <https://reviews.apache.org/r/39614/#comment166170> space src/tests/master_quota_tests.cpp (lines 490 - 491) <https://reviews.apache.org/r/39614/#comment166173> blank line src/tests/master_quota_tests.cpp (lines 494 - 497) <https://reviews.apache.org/r/39614/#comment166179> Let's add a check that total cluster resources contain `quotaResources`. src/tests/master_quota_tests.cpp (lines 495 - 496) <https://reviews.apache.org/r/39614/#comment166174> Fits one line src/tests/master_quota_tests.cpp (line 496) <https://reviews.apache.org/r/39614/#comment166175> Please use constant `ROLE1` src/tests/master_quota_tests.cpp (lines 500 - 503) <https://reviews.apache.org/r/39614/#comment166180> indentation src/tests/master_quota_tests.cpp (line 520) <https://reviews.apache.org/r/39614/#comment166182> How about "Convert `JSON` response to `QuotaStatus` protobuf"? Also, mind backticks. src/tests/master_quota_tests.cpp (line 521) <https://reviews.apache.org/r/39614/#comment166183> `protobuf::parse()` does not compile? src/tests/master_quota_tests.cpp (line 524) <https://reviews.apache.org/r/39614/#comment166169> `RepeatedField::size()` returns `int` - Alexander Rukletsov On Nov. 19, 2015, 2:48 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39614/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 2:48 p.m.) > > > Review request for mesos, Alexander Rukletsov and Bernd Mathiske. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > ------- > > Quota: Added Status Validation Tests. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39614/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
