----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review107206 -----------------------------------------------------------
Overall notes: * Looks like everything is in place (to my knowledge) for this change :) * (Mentioned in the last working group sync) We **may** want to rename the feature to something else, like "oversubscription for reservations". include/mesos/master/allocator.hpp (line 86) <https://reviews.apache.org/r/40339/#comment166207> s/automatically// src/master/flags.cpp (line 441) <https://reviews.apache.org/r/40339/#comment166213> s/automatically// Also, we'll want a more in-depth help message. It should have: * An very, very brief overview of optimistic offers. * What the consequences are for enabling it. * What the consequences are for disabling it. * The default if not specified. - Joseph Wu On Nov. 16, 2015, 1:40 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40339/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 1:40 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Klaus > Ma. > > > Bugs: MESOS-3887 > https://issues.apache.org/jira/browse/MESOS-3887 > > > Repository: mesos > > > Description > ------- > > Added a flag to master to enable optimistic offers. > > > Diffs > ----- > > include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 > src/master/allocator/mesos/allocator.hpp > d2d32af227d66c4030becd4cd64b907a70d25f49 > src/master/allocator/mesos/hierarchical.hpp > cd3c7019952bfe7c1049a9c42a90943b681f1939 > src/master/allocator/mesos/hierarchical.cpp > e9286260f490915327f44492086c1160d5567ac5 > src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 > src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d > src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 > src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 > src/tests/hierarchical_allocator_tests.cpp > 740cfa801ee90417c038308192d1f4f2416f8315 > src/tests/master_allocator_tests.cpp > 646cacd3e16b9e0b72c0b259eecf2760cfb530db > src/tests/reservation_endpoints_tests.cpp > 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 > src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 > src/tests/resource_offers_tests.cpp > bf2fe3ac7b982e31d289a703ae637d8e2b3a2d8a > src/tests/slave_recovery_tests.cpp 2cc7132deb9b8c324aa9dbab0b81643d07377a89 > > Diff: https://reviews.apache.org/r/40339/diff/ > > > Testing > ------- > > Ubuntu 14.04 > make > make check > > > Thanks, > > Guangya Liu > >
