> On Dec. 1, 2015, 1:03 a.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, line 96 > > <https://reviews.apache.org/r/40339/diff/6/?file=1138158#file1138158line96> > > > > Suggestion: rename the variable to `enableReservationOversubscription`.
Done. > On Dec. 1, 2015, 1:03 a.m., Joseph Wu wrote: > > src/master/flags.cpp, lines 439-443 > > <https://reviews.apache.org/r/40339/diff/6/?file=1138163#file1138163line439> > > > > Suggestion: > > > > Whether to enable oversubscription for reservations. If enabled, the > > allocator will optimistically offer reserved-but-unallocated resources to > > other frameworks as revocable resources. Tasks running on revocable > > resources will be evicted when the reserved resources are allocated. Done, thanks Joesph! - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/#review108428 ----------------------------------------------------------- On Nov. 24, 2015, 5:40 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40339/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 5:40 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, > and Klaus Ma. > > > Bugs: MESOS-3887 > https://issues.apache.org/jira/browse/MESOS-3887 > > > Repository: mesos > > > Description > ------- > > Added a flag to master to enable optimistic offers. > > > Diffs > ----- > > include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 > src/master/allocator/mesos/allocator.hpp > 97ee80726ad155917811265a983258b0165d3451 > src/master/allocator/mesos/hierarchical.hpp > 2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 > src/master/allocator/mesos/hierarchical.cpp > aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a > src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 > src/master/flags.cpp 2d58fcd56317897786a8b832c4ccf7f3d7b566e5 > src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02 > src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 > src/tests/hierarchical_allocator_tests.cpp > a45b3dd0a8237fdd080536cb9ab600e71ad939d3 > src/tests/master_allocator_tests.cpp > cba7c36471f93b678d94e1da0251a28a893696b1 > src/tests/master_quota_tests.cpp 330e591f81c7ece7f401042ad159bd6b55881a84 > src/tests/reservation_endpoints_tests.cpp > f4e332327049944000baccd3e607201240a8c5f4 > src/tests/reservation_tests.cpp 1d0a65d5b4c2cb03e49f302176084ef5d602569f > src/tests/resource_offers_tests.cpp > 0bad45dd1dabecc88fef1ab46e8ea26718070b33 > src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 > > Diff: https://reviews.apache.org/r/40339/diff/ > > > Testing > ------- > > Ubuntu 14.04 > make > make check > > > Thanks, > > Guangya Liu > >