> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote:
> > src/master/http.cpp, line 612
> > <https://reviews.apache.org/r/40247/diff/3/?file=1129384#file1129384line612>
> >
> >     The `volumes.flatten()` here looks incorrect to me. For `/reserve`, we 
> > call `flatten` since the `required` resources are the same resources in 
> > their unreserved state. For `/create-volume` however, I think the 
> > `required` resources are the same resources with no `DiskInfo` information.
> >     
> >     For example, suppose we're requested to perform a `CREATE` operation 
> > with a 4GB volume statically reserved for role R. The resources we're 
> > searching for is 4GB disk statically reserved for role R. As opposed to 4GB 
> > volume unreserved, which is what `flatten()` gives us.

Good catch! I fixed this in the most recent version of the patch.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review106966
-----------------------------------------------------------


On Nov. 20, 2015, 10:32 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
>     https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -----
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> -------
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to