----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39387/#review107635 -----------------------------------------------------------
src/docker/executor.cpp (line 324) <https://reviews.apache.org/r/39387/#comment166864> I don't see you handling the else case here? - Timothy Chen On Nov. 23, 2015, 5:07 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39387/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 5:07 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3599 > https://issues.apache.org/jira/browse/MESOS-3599 > > > Repository: mesos > > > Description > ------- > > Make health check run outside for docker container task. > > > Diffs > ----- > > include/mesos/mesos.proto 0b8289fd405bdd3a25ea49151abc4a2ccf486f26 > include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4 > src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2 > > Diff: https://reviews.apache.org/r/39387/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
