> On Nov. 23, 2015, 7:44 p.m., Timothy Chen wrote: > > src/docker/executor.cpp, line 324 > > <https://reviews.apache.org/r/39387/diff/2/?file=1137477#file1137477line324> > > > > I don't see you handling the else case here?
For else case, it would keep use the original health check here. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39387/#review107635 ----------------------------------------------------------- On Nov. 29, 2015, 5:10 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39387/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2015, 5:10 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3599 > https://issues.apache.org/jira/browse/MESOS-3599 > > > Repository: mesos > > > Description > ------- > > Make health check run outside for docker container task. > > > Diffs > ----- > > include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38 > include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd > src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2 > src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02 > > Diff: https://reviews.apache.org/r/39387/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
