----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39712/#review107685 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 598) <https://reviews.apache.org/r/39712/#comment166922> fix the typo (ono -> on) src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 600) <https://reviews.apache.org/r/39712/#comment166924> We need to do a check so that fs_layers size == history size first right? src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 195) <https://reviews.apache.org/r/39712/#comment166928> let's call it layerId instead of just id src/tests/containerizer/provisioner_docker_tests.cpp (line 740) <https://reviews.apache.org/r/39712/#comment166929> What's changed in this JSON? Why do we need to change it? - Timothy Chen On Nov. 23, 2015, 10:16 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39712/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 10:16 p.m.) > > > Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen. > > > Bugs: MESOS-3994 > https://issues.apache.org/jira/browse/MESOS-3994 > > > Repository: mesos > > > Description > ------- > > Refactor registry client/puller to avoid JSON and struct. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp > 3fd84e380f9393a6d46544fb7fc7d24bcb6256ac > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > b17b1b6d9e053af8c80217ea322e99ccab957df1 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 7fca99a3b118b0ac06566455ef003daeef7d8157 > src/tests/containerizer/provisioner_docker_tests.cpp > 9ff27083be91985484960a0d48d909b5594937db > > Diff: https://reviews.apache.org/r/39712/diff/ > > > Testing > ------- > > make check(ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
