> On 十一月 23, 2015, 5:54 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 191-193 > > <https://reviews.apache.org/r/40332/diff/3/?file=1137413#file1137413line191> > > > > Is there a ticket for this? I think we'll want to do this for the MVP. > > Thoughts? > > Alexander Rukletsov wrote: > I am a bit reluctant to expose these constants as master flags, because > they are rather implementation specific. It would be nice to combine all > allocator flags into one `JSON`? file, similar to how we do it for modules. > This requires some work, hence I put a TODO without a ticket and am not > convinced it's mandatory in the MVP.
There are some discussions planning to put all flags to a configuraiton file: http://search-hadoop.com/m/0Vlr6jduNa1HKP7v1/configuration+files&subj=Configuration+file+ - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107607 ----------------------------------------------------------- On 十一月 23, 2015, 11:35 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40332/ > ----------------------------------------------------------- > > (Updated 十一月 23, 2015, 11:35 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Qian Zhang. > > > Bugs: MESOS-3981 > https://issues.apache.org/jira/browse/MESOS-3981 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 > src/master/allocator/mesos/hierarchical.cpp > aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a > > Diff: https://reviews.apache.org/r/40332/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >