-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40392/#review108059
-----------------------------------------------------------

Ship it!



src/master/quota_handler.cpp (line 302)
<https://reviews.apache.org/r/40392/#comment167432>

    s/overwrite/override/



src/master/quota_handler.cpp (line 303)
<https://reviews.apache.org/r/40392/#comment167433>

    should we lowercase the input value?



src/tests/master_quota_tests.cpp (lines 508 - 509)
<https://reviews.apache.org/r/40392/#comment167435>

    ```
    Checks that the force flag overrides the `capacityHeuristic` check.
    ```


- Joris Van Remoortere


On Nov. 20, 2015, 9:39 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40392/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 9:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3911
>     https://issues.apache.org/jira/browse/MESOS-3911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added force flag to override quota capacityHeuristic check.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40392/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to