-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40732/#review108150
-----------------------------------------------------------



src/tests/resources_tests.cpp (line 1534)
<https://reviews.apache.org/r/40732/#comment167498>

    We can not change this to `EXPECT_DOUBLE_EQ` because it's used to check 
`operator==` in `Resources`. I think we can check the source code of 
`CHECK_NEAR` and re-use it in `Scalar::operator==`.


- Klaus Ma


On Nov. 26, 2015, 2:52 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40732/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 2:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is an existing test case to check precision of resource reservations, 
> but would have always failed due to double precision errors. Forcing the test 
> case to use EXPECT_DOUBE_EQ instead of EXPECT_EQ (strict equality)
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 
> 
> Diff: https://reviews.apache.org/r/40732/diff/
> 
> 
> Testing
> -------
> 
> Ran make check against 40730
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to