> On Nov. 26, 2015, 3:35 p.m., Neil Conway wrote:
> > src/tests/resources_tests.cpp, line 1526
> > <https://reviews.apache.org/r/40732/diff/1/?file=1147238#file1147238line1526>
> >
> >     If we're going to enable this test, the comment should be removed.

Based on Klaus Ma's comments will either drop this commit, or if he agrees will 
remove this comment and keep it enabled.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40732/#review108141
-----------------------------------------------------------


On Nov. 26, 2015, 6:52 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40732/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 6:52 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is an existing test case to check precision of resource reservations, 
> but would have always failed due to double precision errors. Forcing the test 
> case to use EXPECT_DOUBE_EQ instead of EXPECT_EQ (strict equality)
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 
> 
> Diff: https://reviews.apache.org/r/40732/diff/
> 
> 
> Testing
> -------
> 
> Ran make check against 40730
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to