-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108054
-----------------------------------------------------------



support/mesos-license.py (line 29)
<https://reviews.apache.org/r/40445/#comment167428>

    best not to have spaces in the logger's name



support/mesos-license.py (line 30)
<https://reviews.apache.org/r/40445/#comment167429>

    is this dead code? please remove
    However, I'd like to see the log-level to be set to INFO by defaul and 
driven by customer option (eg, a --debug or -v,--verbose flag) to be DEBUG 
on-demand.



support/mesos-license.py (line 36)
<https://reviews.apache.org/r/40445/#comment167430>

    blank line between method definition
    
    IMO both methods are redundant, but please derive it from `Exception` 
(instead of `BaseEx`) unless you have a good reason for it.



support/mesos-license.py (line 39)
<https://reviews.apache.org/r/40445/#comment167431>

    please add epydoc to the method and explain what the @param is supposed to 
be (also @type)



support/mesos-license.py (lines 43 - 47)
<https://reviews.apache.org/r/40445/#comment167537>

    this is a bit on the ugly side of things :)
    and not very readable either (not to mention, not very extensible).
    
    Ideally, on would use a combination of RegEx and a comprehension list.


- Marco Massenzio


On Nov. 25, 2015, 9:59 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 9:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
>     https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -----
> 
>   support/mesos-license.py PRE-CREATION 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> -------
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> ---------------------
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to