> On 十一月 28, 2015, 3:39 a.m., Guangya Liu wrote: > > https://github.com/apache/mesos/blob/master/src/master/master.cpp#L4322 > > also needs an update > > Alexander Rukletsov wrote: > I'm not sure about that one. I think it's more readable how it's now.
I think that you already did some similiar update in hierarchical.cpp, this makes the code more simple to understand. // First remove the old oversubscribed resources from the total. slaves[slaveId].total = slaves[slaveId].total.nonRevocable(); - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40756/#review108250 ----------------------------------------------------------- On 十一月 27, 2015, 2:49 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40756/ > ----------------------------------------------------------- > > (Updated 十一月 27, 2015, 2:49 p.m.) > > > Review request for mesos, Ian Downes and Michael Park. > > > Bugs: MESOS-4020 > https://issues.apache.org/jira/browse/MESOS-4020 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/http.cpp 692ea3fba2e48e8f8b5257a6bb6ea8a40609013b > src/master/allocator/mesos/hierarchical.cpp > 31ed62efb5b1a2edb567f43d37559c5914e0665e > src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745 > src/slave/slave.cpp 9055f2a789cb19f3579c15a379ea505dfef0578c > > Diff: https://reviews.apache.org/r/40756/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
