> On Nov. 29, 2015, 5:35 p.m., Michael Park wrote: > > src/master/master.cpp, lines 4310-4311 > > <https://reviews.apache.org/r/40756/diff/2/?file=1147967#file1147967line4310> > > > > Should we use it here as well? > > > > ```cpp > > slave->totalResources = > > slave->totalResources.nonRevocable() + > > oversubscribedResources.revocable(); > > ```
Oh, I see that Guangya has mentioned this already. Although our suggestions seem to be a bit different. I'll leave this one upto you Alex :) - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40756/#review108270 ----------------------------------------------------------- On Nov. 27, 2015, 2:49 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40756/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 2:49 p.m.) > > > Review request for mesos, Ian Downes and Michael Park. > > > Bugs: MESOS-4020 > https://issues.apache.org/jira/browse/MESOS-4020 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/http.cpp 692ea3fba2e48e8f8b5257a6bb6ea8a40609013b > src/master/allocator/mesos/hierarchical.cpp > 31ed62efb5b1a2edb567f43d37559c5914e0665e > src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745 > src/slave/slave.cpp 9055f2a789cb19f3579c15a379ea505dfef0578c > > Diff: https://reviews.apache.org/r/40756/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
