-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40767/#review108327
-----------------------------------------------------------



src/common/resources.cpp (lines 962 - 964)
<https://reviews.apache.org/r/40767/#comment167759>

    Do you know about Option's getOrElse? You can avoid these ternary 
expressions.
    
    Also the ? needs a space in the second line here.


- Ben Mahler


On Nov. 27, 2015, 1:44 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40767/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2015, 1:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Avinash sridharan, Klaus Ma, 
> Mandeep Chadha, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Addendum to https://reviews.apache.org/r/40730. Not squeeky clean yet, but 
> good enough IMHO until we bring about MESOS-3997, which will change every 
> piece of code like this.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 5cf04ea93e7567107e6664ed56733b7b54dd321b 
> 
> Diff: https://reviews.apache.org/r/40767/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Reply via email to