> On Nov. 30, 2015, 9:10 a.m., Ben Mahler wrote: > > src/common/resources.cpp, lines 963-965 > > <https://reviews.apache.org/r/40767/diff/1/?file=1147935#file1147935line963> > > > > Do you know about Option's getOrElse? You can avoid these ternary > > expressions. > > > > Also the ? needs a space in the second line here. > > Bernd Mathiske wrote: > Addressed in https://reviews.apache.org/r/40903/.
Good point! Thanks! - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108327 ----------------------------------------------------------- On Nov. 27, 2015, 5:44 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40767/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 5:44 a.m.) > > > Review request for mesos, Alexander Rukletsov, Avinash sridharan, Klaus Ma, > Mandeep Chadha, Neil Conway, and Till Toenshoff. > > > Bugs: MESOS-3552 > https://issues.apache.org/jira/browse/MESOS-3552 > > > Repository: mesos > > > Description > ------- > > Addendum to https://reviews.apache.org/r/40730. Not squeeky clean yet, but > good enough IMHO until we bring about MESOS-3997, which will change every > piece of code like this. > > > Diffs > ----- > > src/common/resources.cpp 5cf04ea93e7567107e6664ed56733b7b54dd321b > > Diff: https://reviews.apache.org/r/40767/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
