----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40454/#review108332 -----------------------------------------------------------
Ship it! Ship It! - haosdent huang On Nov. 18, 2015, 9:52 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40454/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 9:52 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3753 > https://issues.apache.org/jira/browse/MESOS-3753 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/containerizer/isolator_tests.cpp > 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd > src/tests/containerizer/provisioner_docker_tests.cpp > edfbb6fe932173dcbb15133e0eb685d86dd09c00 > src/tests/mesos.cpp 766a51cddc8801d5e79188f80e9ce0828598c8b9 > src/tests/module_tests.cpp 28c71b0c1960bad4933f86d35fe8a0248fef326e > > Diff: https://reviews.apache.org/r/40454/diff/ > > > Testing > ------- > > Picked https://reviews.apache.org/r/40268/ which exposes the bad cleanup > after SSL-reinitializing tests. > > Then: > `make check GTEST_FILTER="*RegistryClientTest*:*ExecutorHttpApiTest*"` > > The `RegistryClientTest` involve some reinitialization of SSL variables. The > `ExecutorHttpApiTest` spawns sockets. If the SSL variables are not cleaned > up, the second test will try to use SSL sockets against non-SSL endpoints. > > > Thanks, > > Joseph Wu > >
