----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40454/#review108375 -----------------------------------------------------------
Ship it! Ship It! - Jan Schlicht On Nov. 30, 2015, 7:15 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40454/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 7:15 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Till > Toenshoff. > > > Bugs: MESOS-3975 > https://issues.apache.org/jira/browse/MESOS-3975 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp > b98461e65c2d6e97bce8e7906b4cba87d8bfd35c > src/tests/mesos.cpp a75182ec7f6d0c6063bbb36a6ccf4e8a4a81c8dd > src/tests/module_tests.cpp b5cfbcd4885a4f2c20b19e00958fedda81afa6e0 > > Diff: https://reviews.apache.org/r/40454/diff/ > > > Testing > ------- > > Picked https://reviews.apache.org/r/40268/ which exposes the bad cleanup > after SSL-reinitializing tests. > > Then: > `make check GTEST_FILTER="*RegistryClientTest*:*ExecutorHttpApiTest*"` > > The `RegistryClientTest` involve some reinitialization of SSL variables. The > `ExecutorHttpApiTest` spawns sockets. If the SSL variables are not cleaned > up, the second test will try to use SSL sockets against non-SSL endpoints. > > > Thanks, > > Joseph Wu > >
