----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40453/#review108345 -----------------------------------------------------------
Ship it! Ship It! - Till Toenshoff On Nov. 18, 2015, 9:52 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40453/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 9:52 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3753 > https://issues.apache.org/jira/browse/MESOS-3753 > > > Repository: mesos > > > Description > ------- > > Tests that reinitiailize SSL configuration only change environment variables > upon setup. This means the changed environment will stay intact after the > test. This may lead to unexpected results in subsequent tests. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 54885ec359df947f6d31375d4c2a32cae587f845 > > Diff: https://reviews.apache.org/r/40453/diff/ > > > Testing > ------- > > See next review. > > > Thanks, > > Joseph Wu > >