----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40453/#review108374 -----------------------------------------------------------
Ship it! Ship It! - Jan Schlicht On Nov. 30, 2015, 7:15 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40453/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 7:15 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Till > Toenshoff. > > > Bugs: MESOS-3975 > https://issues.apache.org/jira/browse/MESOS-3975 > > > Repository: mesos > > > Description > ------- > > Tests that reinitiailize SSL configuration only change environment variables > upon setup. This means the changed environment will stay intact after the > test. This may lead to unexpected results in subsequent tests. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 95e19845f90f648b148a39e7791eb4d4df939876 > > Diff: https://reviews.apache.org/r/40453/diff/ > > > Testing > ------- > > See next review. > > > Thanks, > > Joseph Wu > >