> On Nov. 30, 2015, 6:15 a.m., Bernd Mathiske wrote:
> > src/tests/reservation_tests.cpp, line 248
> > <https://reviews.apache.org/r/40731/diff/1/?file=1147237#file1147237line248>
> >
> >     s/RESERVE/UNRESERVE/ ?
> >     
> >     What is the intention here? Please explain.
> 
> Avinash sridharan wrote:
>     Can you clarify this comment? The idea here seems to be to generate 
> multiple CPU resource requests. Hence the RESERVE?

The misleading comment near this is gone and a new one is there that addresses 
the issue. Thx


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108313
-----------------------------------------------------------


On Dec. 2, 2015, 12:27 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 12:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding the test framework submitted by Mandeep (@mchadha) 
> https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to