----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108696 -----------------------------------------------------------
src/tests/reservation_tests.cpp (line 237) <https://reviews.apache.org/r/40731/#comment168152> More customary indentation: EXPECT_CALL(sched, resourceOffers(&driver, _)) .WillOnce(FutureArg<1>(&offers)); src/tests/reservation_tests.cpp (line 243) <https://reviews.apache.org/r/40731/#comment168154> Please put blanks after "//" on theleft. Typos: - calculate - comparison Never use apostrophy abbreviations where not necessary: s/isn't/is not/ Missing period at sentence end after MESOS-3552. src/tests/reservation_tests.cpp (line 245) <https://reviews.apache.org/r/40731/#comment168156> Where exactly is "over here"? Does the wait statement contain floating point comparisons? src/tests/reservation_tests.cpp (line 254) <https://reviews.apache.org/r/40731/#comment168157> Missing blanks after "//". - Bernd Mathiske On Dec. 2, 2015, 12:27 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40731/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 12:27 a.m.) > > > Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil > Conway. > > > Bugs: MESOS-3552 > https://issues.apache.org/jira/browse/MESOS-3552 > > > Repository: mesos > > > Description > ------- > > Adding the test framework submitted by Mandeep (@mchadha) > https://reviews.apache.org/r/39056/ > > > Diffs > ----- > > src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169 > > Diff: https://reviews.apache.org/r/40731/diff/ > > > Testing > ------- > > Ran make check after adding Mandeep's test case to the GTEST framework. > > > Thanks, > > Avinash sridharan > >
