> On Dec. 1, 2015, 10:40 a.m., Bernd Mathiske wrote:
> > src/hdfs/hdfs.cpp, line 100
> > <https://reviews.apache.org/r/40806/diff/1/?file=1149436#file1149436line100>
> >
> >     This block seems to be reusable in a lot of situations. Any chance we 
> > could abstract it and make it part of class Subprocess?
> >     
> >     In a separate ticket, I suppose. ==> Place a TODO here?

Due to some controversy in the Subprocess patch. I move the logic to hdfs.cpp 
as a helper and that slightly simplies the logics here.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40806/#review108475
-----------------------------------------------------------


On Dec. 4, 2015, 12:20 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40806/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made HDFS::exists asynchronous.
> 
> This also fixed a bug in the orignal code: the original code never returns 
> false.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp ac933b6a8636af3356f3d6a99656c0185077c262 
>   src/hdfs/hdfs.hpp 6bdeedf8934a681b32fca8edc251488f4213dd07 
>   src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b 
> 
> Diff: https://reviews.apache.org/r/40806/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to