> On Dec. 4, 2015, 10:51 a.m., Bernd Mathiske wrote: > > src/hdfs/hdfs.cpp, line 143 > > <https://reviews.apache.org/r/40806/diff/3/?file=1153438#file1153438line143> > > > > Maybe we can get some extra info about what subprocess failed to be > > reaped by capturing some values from above in the closure?
Hum, this is pretty standard in our code base. I don't think adding the command itself to the log will help debugging a lot. Let me know if you insist. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/#review108960 ----------------------------------------------------------- On Dec. 4, 2015, 12:45 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40806/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 12:45 a.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-3951 > https://issues.apache.org/jira/browse/MESOS-3951 > > > Repository: mesos > > > Description > ------- > > Made HDFS::exists asynchronous. > > This also fixed a bug in the orignal code: the original code never returns > false. > > > Diffs > ----- > > src/cli/execute.cpp ac933b6a8636af3356f3d6a99656c0185077c262 > src/hdfs/hdfs.hpp 6bdeedf8934a681b32fca8edc251488f4213dd07 > src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b > > Diff: https://reviews.apache.org/r/40806/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
