----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40999/#review109068 -----------------------------------------------------------
src/tests/reservation_tests.cpp (lines 1663 - 1664) <https://reviews.apache.org/r/40999/#comment168490> You can be more explicit in your expectations (about batch allocations) by using `Clock::advance(flags.allocation_interval)`. Using the above will ensure that only one allocation cycle can be triggered. - Joseph Wu On Dec. 4, 2015, 4:33 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40999/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 4:33 p.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Bugs: MESOS-4067 > https://issues.apache.org/jira/browse/MESOS-4067 > > > Repository: mesos > > > Description > ------- > > Fixed flakiness in ReservationTest.ACLMultipleOperations. > > > Diffs > ----- > > src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624 > > Diff: https://reviews.apache.org/r/40999/diff/ > > > Testing > ------- > > `GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh > --gtest_repeat=2000 --gtest_break_on_failure` > > This test does not fail often unless the `allocation_interval` is reset to a > shorter period (5ms, for example). The patch following this one implements > this change for all tests in `ReservationTest` to reduce their potential for > flakiness (https://reviews.apache.org/r/41000/). > > > Thanks, > > Greg Mann > >
