> On Dec. 5, 2015, 12:54 a.m., Joseph Wu wrote:
> > src/tests/reservation_tests.cpp, lines 1663-1664
> > <https://reviews.apache.org/r/40999/diff/1/?file=1154188#file1154188line1663>
> >
> >     You can be more explicit in your expectations (about batch allocations) 
> > by using `Clock::advance(flags.allocation_interval)`.
> >     
> >     Using the above will ensure that only one allocation cycle can be 
> > triggered.

Great suggestion, thanks Joseph! :-)


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40999/#review109068
-----------------------------------------------------------


On Dec. 8, 2015, 4:57 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40999/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 4:57 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-4067
>     https://issues.apache.org/jira/browse/MESOS-4067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed flakiness in ReservationTest.ACLMultipleOperations.
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp eccbb8f8a02b65b26f34e020e736afe0445a6d0d 
> 
> Diff: https://reviews.apache.org/r/40999/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh 
> --gtest_repeat=2000 --gtest_break_on_failure`
> 
> To reproduce the original test failure, you may have to set 
> `allocation_interval` to a shorter period (5ms, for example).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to