-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review109167
-----------------------------------------------------------

Ship it!



docs/oversubscription.md (line 201)
<https://reviews.apache.org/r/41042/#comment168630>

    s/QoS/quality of service for regular tasks/ or something in the manner :)



docs/oversubscription.md (line 202)
<https://reviews.apache.org/r/41042/#comment168631>

    How do you 'perform' QoS? :) It's ensuring the total system load doesn't 
exceed a threshold and thereby, simplistically, try to avoid cpu congestion.



docs/oversubscription.md (line 203)
<https://reviews.apache.org/r/41042/#comment168632>

    It comes as a module parameter, right? That can live in a file as well.



docs/oversubscription.md (line 316)
<https://reviews.apache.org/r/41042/#comment168635>

    We should maybe describe that these are standard unix load averages.



docs/oversubscription.md (line 329)
<https://reviews.apache.org/r/41042/#comment168633>

    Let's expand to s/5min/5 minutes/



docs/oversubscription.md (line 330)
<https://reviews.apache.org/r/41042/#comment168634>

    Same here for 15min


- Niklas Nielsen


On Dec. 7, 2015, 9:18 a.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 9:18 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-4076
>     https://issues.apache.org/jira/browse/MESOS-4076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added description to _Writing a custom QoS controller_ and _Configuring  
> oversubscription_ sections.
> 
> 
> Diffs
> -----
> 
>   docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f 
> 
> Diff: https://reviews.apache.org/r/41042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to