-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41001/
-----------------------------------------------------------

(Updated Dec. 10, 2015, 2:02 a.m.)


Review request for mesos, Jie Yu and Michael Park.


Changes
-------

Addressed comment.


Repository: mesos


Description
-------

Improved 'ReservationTest.ACLMultipleOperations'.


Diffs (updated)
-----

  src/tests/reservation_tests.cpp 3405b47c367e3c20e2a9139ab95dd8fd1805ea8d 

Diff: https://reviews.apache.org/r/41001/diff/


Testing
-------

`GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh 
--gtest_repeat=1000 --gtest_break_on_failure`

This test was originally written to test the interaction of multiple 
RESERVE/UNRESERVE/LAUNCH operations in a single `acceptOffers()` call when 
authorization is enabled. In order to probe the effect of authorization on this 
interaction, some operations should fail due to failed authorization. However, 
this test included operations that failed simply because they were malformed. I 
altered the test so that now operations will fail due to failed authorization, 
which tests the desired functionality more precisely.


Thanks,

Greg Mann

Reply via email to