> On Dec. 9, 2015, 5:56 a.m., Michael Park wrote: > > src/tests/reservation_tests.cpp, line 1660 > > <https://reviews.apache.org/r/41001/diff/2/?file=1156013#file1156013line1660> > > > > This one gets dropped because it's an invalid unreserve request, right? > > This is still what's intended to be tested?
Ah sorry, I intended to make this a valid request. Fixed. > On Dec. 9, 2015, 5:56 a.m., Michael Park wrote: > > src/tests/reservation_tests.cpp, lines 1703-1704 > > <https://reviews.apache.org/r/41001/diff/2/?file=1156013#file1156013line1703> > > > > Just to make sure I understand the intent of this patch, this is the > > part where the operations are dropped due to authorization rather than > > invalid request. Correct? Yep, that's correct. In `master.cpp`, `accept()` passes a couple lists along to its continuation: one of them is a list of authorization results, another is a list of operations, and they are iterated through at the same time (the authorization at a given index corresponds to the operation at the same index). Performing both successful and failed RESERVE/UNRESERVE operations, along with an always-successful LAUNCH operation, tests that these authorization results are being passed to the continuation, and in the correct order. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41001/#review109458 ----------------------------------------------------------- On Dec. 10, 2015, 2:02 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41001/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 2:02 a.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Repository: mesos > > > Description > ------- > > Improved 'ReservationTest.ACLMultipleOperations'. > > > Diffs > ----- > > src/tests/reservation_tests.cpp 3405b47c367e3c20e2a9139ab95dd8fd1805ea8d > > Diff: https://reviews.apache.org/r/41001/diff/ > > > Testing > ------- > > `GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh > --gtest_repeat=1000 --gtest_break_on_failure` > > This test was originally written to test the interaction of multiple > RESERVE/UNRESERVE/LAUNCH operations in a single `acceptOffers()` call when > authorization is enabled. In order to probe the effect of authorization on > this interaction, some operations should fail due to failed authorization. > However, this test included operations that failed simply because they were > malformed. I altered the test so that now operations will fail due to failed > authorization, which tests the desired functionality more precisely. > > > Thanks, > > Greg Mann > >
