----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review109993 -----------------------------------------------------------
src/common/resources.cpp (line 103) <https://reviews.apache.org/r/40375/#comment169741> Missing a comment here about optional protobuf fields with defaults. src/common/resources.cpp (lines 1380 - 1382) <https://reviews.apache.org/r/40375/#comment169746> I'm not sure if this is necessary. To be as backwards compatible as possible, the `USAGE_SLACK` type would output as `{REV}`. But is there any parsing of stringified `Resources` between the master and agent? src/common/resources.cpp (lines 1404 - 1405) <https://reviews.apache.org/r/40375/#comment169748> This comment should be updated. src/v1/resources.cpp (line 97) <https://reviews.apache.org/r/40375/#comment169749> Ditto: comment here. src/v1/resources.cpp (lines 1364 - 1366) <https://reviews.apache.org/r/40375/#comment169750> Ditto: not necessary, perhaps. src/v1/resources.cpp (lines 1388 - 1389) <https://reviews.apache.org/r/40375/#comment169751> Ditto: Update comment. - Joseph Wu On Dec. 10, 2015, 5:21 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40375/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 5:21 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van > Remoortere. > > > Bugs: MESOS-3888 > https://issues.apache.org/jira/browse/MESOS-3888 > > > Repository: mesos > > > Description > ------- > > MESOS-3888: We need to distinguish revocable resource for usage slack and > allocation slack. > > > Diffs > ----- > > include/mesos/mesos.proto 8ca2130 > include/mesos/v1/mesos.proto 8f357b0 > src/common/resources.cpp 5a79817 > src/tests/resources_tests.cpp ce47bac > src/v1/resources.cpp d300842 > > Diff: https://reviews.apache.org/r/40375/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Klaus Ma > >
