-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review113094
-----------------------------------------------------------

Ship it!


A few comment suggestions, but otherwise LGTM.


include/mesos/mesos.proto (line 661)
<https://reviews.apache.org/r/40375/#comment173600>

    s/that controlled/controlled/



include/mesos/mesos.proto (lines 661 - 662)
<https://reviews.apache.org/r/40375/#comment173601>

    s/by oversubscription for allocations (QoSController & 
ResourceEstimator)/by the `QoSController` and `ResourceEstimator`/
    
    s/`ResourceEstimator`/The `ResourceEstimator`/



include/mesos/mesos.proto (line 663)
<https://reviews.apache.org/r/40375/#comment173602>

    s/marks allocated by not used resources/marks resources that are allocated 
but not utilized/



include/mesos/mesos.proto (line 667)
<https://reviews.apache.org/r/40375/#comment173603>

    s/that controlled/controlled/



include/mesos/mesos.proto (lines 667 - 668)
<https://reviews.apache.org/r/40375/#comment173604>

    s/by oversubscription for reservations (Allocator)/by the allocator, when 
oversubscription for reservations is enabled/



include/mesos/mesos.proto (lines 668 - 669)
<https://reviews.apache.org/r/40375/#comment173605>

    s/reserved by not allocated resources/resources that are reserved but not 
allocated/


- Joseph Wu


On Dec. 12, 2015, 7:19 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 7:19 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
>     https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8ca2130 
>   include/mesos/v1/mesos.proto 8f357b0 
>   src/common/resources.cpp 5a79817 
>   src/tests/resources_tests.cpp ce47bac 
>   src/v1/resources.cpp d300842 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to