> On Dec. 11, 2015, 2:41 p.m., Bernd Mathiske wrote: > > src/master/master.cpp, line 509 > > <https://reviews.apache.org/r/39043/diff/19/?file=1158817#file1158817line509> > > > > Why do we have a vector then? > > Why do we have plural variable names then? > > I suspect this is an MVP decision. > > Then it needs a TODO hinting > > that plural will make sense later. > > > > Personally, I would find it cleaner to use singular and change it to > > plural (and vector) only at the time when the post-MVP actually gets worked > > upon.
It is the same pattern used for non http authenticators and authorizers modules. Where we support only one but the infrastructure is there for the rest. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109955 ----------------------------------------------------------- On Dec. 11, 2015, 3:06 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39043/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 3:06 p.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till > Toenshoff. > > > Bugs: MESOS-3756 > https://issues.apache.org/jira/browse/MESOS-3756 > > > Repository: mesos > > > Description > ------- > > 1. Adds a flag to load an HTTP Authenticator module from the flags. > 2. If provided, uses the credentials file to initialize the default HTTP > Authenticator. > 3. Updates the existing endpoints which implement their own basic HTTP > authenticator with the libprocess one. > 4. Updates one test which expected the wrong results since now credentials > are checked before the body of the request. > > > Diffs > ----- > > src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759 > src/master/constants.cpp 98ea7c8f1e7c3057cfe941f82f1b71f7731a8f32 > src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 > src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 > src/master/http.cpp 37fbcb93074fe189133161afaa28046dc2ad0731 > src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 > src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4 > src/master/quota_handler.cpp 11167879b2480d9c8dd6398ca39c479089ec2272 > > Diff: https://reviews.apache.org/r/39043/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
