-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40348/#review110319
-----------------------------------------------------------



docs/authorization.md (line 30)
<https://reviews.apache.org/r/40348/#comment170132>

    I wonder if there should be some mention of the behavior of `set_quotas` 
when no principal is set?



docs/authorization.md (line 31)
<https://reviews.apache.org/r/40348/#comment170131>

    In the case of `set_quotas`, this is an operator username isn't it?



src/master/flags.cpp (lines 265 - 266)
<https://reviews.apache.org/r/40348/#comment170134>

    Perhaps for a more realistic example this could have just one principal, 
with multiple roles?


- Greg Mann


On Dec. 4, 2015, 2:28 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40348/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van 
> Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Documented quota authorization.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb 
>   src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
> 
> Diff: https://reviews.apache.org/r/40348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to