----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/#review110468 -----------------------------------------------------------
bootstrap (lines 16 - 23) <https://reviews.apache.org/r/41243/#comment170395> We do need to provide something here since we cannot assume e.g., GNU coreutils' `readlink`, but I am not convinced that adding condensed advanced sh will be maintainable. Since we already assume some Python elsewhere, why not just fork out to some tooling there, e.g., `os.path` (note inverted parameter order)? python -c "import os.path; print os.path.relpath('"$path"', '"$common"')" bootstrap (lines 28 - 29) <https://reviews.apache.org/r/41243/#comment170397> All these vars should probably be quoted. bootstrap (lines 32 - 33) <https://reviews.apache.org/r/41243/#comment170398> quoting - Benjamin Bannier On Dec. 15, 2015, 1:09 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41243/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 1:09 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and > Vinod Kone. > > > Bugs: MESOS-4125 > https://issues.apache.org/jira/browse/MESOS-4125 > > > Repository: mesos > > > Description > ------- > > When building from git, bootstrap will (among other things) install > pre-commit and post-rewrite hooks into the .git/hooks directory of the > mesos tree. However the current implementation always assumes that .git > exists in the same directory as the bootstrap file. This may not always > be true. > > Most notably, it is not true if the mesos tree is included as a > submodule inside another project. When included as a submodule, .git is > no longer a directory, but rather a file whose text contains a pointer > back to the actual location of the .git folder inside the containing > project. To get at this directory, we need to run 'git rev-parse > --git-dir' instead of simply assuming that the local .git is the proper > directory. > > > Diffs > ----- > > bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 > > Diff: https://reviews.apache.org/r/41243/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
