> On Dec. 15, 2015, 10:43 a.m., Benjamin Bannier wrote:
> >

I agree with all of your comments, and the code has been updated appropriately.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41243/#review110468
-----------------------------------------------------------


On Dec. 15, 2015, 3:10 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41243/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 3:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-4125
>     https://issues.apache.org/jira/browse/MESOS-4125
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When building from git, bootstrap will (among other things) install
> pre-commit and post-rewrite hooks into the .git/hooks directory of the
> mesos tree. However the current implementation always assumes that .git
> exists in the same directory as the bootstrap file. This may not always
> be true.
> 
> Most notably, it is not true if the mesos tree is included as a
> submodule inside another project. When included as a submodule, .git is
> no longer a directory, but rather a file whose text contains a pointer
> back to the actual location of the .git folder inside the containing
> project. To get at this directory, we need to run 'git rev-parse
> --git-dir' instead of simply assuming that the local .git is the proper
> directory.
> 
> 
> Diffs
> -----
> 
>   bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 
> 
> Diff: https://reviews.apache.org/r/41243/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to