> On Dec. 14, 2015, 11:16 p.m., Greg Mann wrote:
> > src/tests/master_quota_tests.cpp, line 1061
> > <https://reviews.apache.org/r/39520/diff/7/?file=1158401#file1158401line1061>
> >
> >     In addition to verifying the OK response, is it possible to verify by 
> > another means that the quota has been set to the correct value for the 
> > correct principal?

It is possible to verify this by checking `QuotaInfo` that is provided to the 
allocator. Other tests do this as well and I will implement it. At the moment 
the principal is not stored in `QuotaInfo`, so it is not possible to check for 
that yet. But storing it will be necessary for the quota removal authorization, 
hence I'd add a TODO for that and implement it later.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39520/#review110323
-----------------------------------------------------------


On Dec. 15, 2015, 12:09 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39520/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 12:09 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4082
>     https://issues.apache.org/jira/browse/MESOS-4082
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Added authentication, authorization tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp b5fb3c30e4c53bf3bf081c2a9a30a327f2c7c880 
>   src/tests/master_quota_tests.cpp 0473869783a714766ed26fff61d7f8c56342df74 
> 
> Diff: https://reviews.apache.org/r/39520/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to