> On Dec. 14, 2015, 4:18 p.m., Alexander Rukletsov wrote: > > I would suggest to add some more test cases: > > - Request does not contain a principal (in absence of authz quota can be > > set); > > - Request does not contain a principal, ACLs allow `ANY` to set quota for > > role "prod" (absence of principal maps to `ANY`). > > Jan Schlicht wrote: > The new test fixture `AuthorizedQuotaSetRequestWithoutPrincipal` now > tests for authorization with an empty principal if authentication is disabled. > `AuthorizationTest.SetQuota` now includes a rule where `ANY` can set > quota for role "test" and tests that rule.
I still do not see a tests where **both** authn and authz are disabled. Let's add this test. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39520/#review110229 ----------------------------------------------------------- On Dec. 18, 2015, 9:12 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39520/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 9:12 a.m.) > > > Review request for mesos, Alexander Rukletsov and Till Toenshoff. > > > Bugs: MESOS-4082 > https://issues.apache.org/jira/browse/MESOS-4082 > > > Repository: mesos > > > Description > ------- > > Quota: Added authentication, authorization tests. > > > Diffs > ----- > > src/tests/authorization_tests.cpp dcf348acc75b143e3a854bde17e6042dc90599d5 > src/tests/master_quota_tests.cpp 0473869783a714766ed26fff61d7f8c56342df74 > > Diff: https://reviews.apache.org/r/39520/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
